3

Ok so this is mind boggling to me. Every time I've used something similiar before it works. I added messages to be displayed before everything happened to see where it would, and it never got past the wait.

Events
     Unit - A unit Begins casting an ability
Conditions
     (Ability being cast) Equal to Berserking Power [E]
Actions
     Unit Group - Add(Triggering unit) to heroSpellUG[(Player number of (Owner of (Triggering unit)))]
     -Unit Group - Pick every unit in heroSpellUG[(Player number of (Owner of (Triggering unit)))]
           Unit - Add Berserking Power Damage to (Picked Unit)
           Unit - Set level of Berserking Power Damage for (Picked Unit) to (Level of Berserking Power [E] for (Picked Unit))
           Wait (5.00 + (Real((Level of Berserking Power [E] for (Picked Unit))))) game-time seconds
           Unit - Remove Berserking Power Damage from (Picked Unit)
           Unit Group - Remove (Picked Unit) from heroSpellUG[(Player number of (Owner of (Picked Unit)))]


So I guess my question is, why is the Wait not completing. I had it display what the time to wait was and it said 6 seconds at level one. Any help would be appreciated.

Tetrad
  • 30,124
  • 12
  • 94
  • 143

4 Answers4

1

Umm, i have a few things to mention here ...

First you're using GUI which is in WC3 really weak and not useful, try to learn Jass and vJass they're more powerful

Second, there are plenty of forums made for Wc3 the best i know is a wc3c. They can help you better than we can do.

Third, it seems that you are trying to do something like a berserk skill, you should try to create a dummy unit add it an ability with the buff and the duration you want and let it cast the ability on all units u want to have the buff.

Forth, waits in picks are stupid, because they will go like this: First unit gets buffed - 6 seconds wait - debuff - Second unit gets buffed - 6 seconds wait - etc. I guess you don't want it to happen like this

awildturtok
  • 51
  • 3
1

Not sure what you're trying to accomplish, but that doesn't look right at all:

  • You are calling a wait inside the loop, meaning if there are two units in the heroSpellUG group, the second unit will not get the Berserking Power Damage attribute until after Berserking Power Damage has been added and removed from the first unit (~ 6 seconds later)
  • Because this is being called asynchronously (every time a unit casts Berserking Power), and you are adding and removing from a unit-group inside a loop, you are almost certainly opening yourself up to race conditions that occur when two units cast Berserking Power at the same time.

It's been a while since I've done any WC3 scripting, but what you probably want to do is add the ability to only that unit, then create a timer which takes away the ability when it expires.

BlueRaja - Danny Pflughoeft
  • 7,985
  • 2
  • 35
  • 41
0

Try it with just one unit triggering the effect. When multiple units trigger the effect the they will only receive your buff sequentially. Also unit groups and picks will create memory leaks, try to avoid them. Also try it with a static time, and add a message at the very end of the script to debug it.

Riki
  • 683
  • 4
  • 11
0

What do you mean by "not completing"?
Does it never end?
Does it never happen?

You might wanna ask on www.hiveworkshop.com where your chances to get an answer are 100000 times greater than on www.wc3c.net...

Edit: Seshiro said

Forth, waits in picks are stupid, because they will go like this: First unit gets buffed - 6 seconds wait - debuff - Second unit gets buffed - 6 seconds wait - etc. I guess you don't want it to happen like this

This is true, but also during the wait the trigger may run again, so the first unit in the group (UnitGroups are queues) will get the effect lots of times and the others will get it slowly...

Vercas
  • 101
  • 3