2

I have this regex on Javascript :

var myString="[email protected]";
var mailValidator = new RegExp("\w+([-+.]\w+)*@\w+([-.]\w+)*\.\w+([-.]\w+)*");
if (!mailValidator.test(myString))
{
    alert("incorrect");
}

but it shouldn't alert "incorrect" with [email protected].

It should return "incorrect" for aaaaaa.com instead (as example).

Where am I wrong?

Pointy
  • 405,095
  • 59
  • 585
  • 614
markzzz
  • 47,390
  • 120
  • 299
  • 507
  • If you're trying to use a regexp to validate an email address, use [this one instead](http://stackoverflow.com/questions/46155/validate-email-address-in-javascript). – Matt Ball Jan 26 '12 at 15:14
  • possible duplicate of [Why this javascript regex doesn't work?](http://stackoverflow.com/questions/7427731/why-this-javascript-regex-doesnt-work) – Jerry Mar 31 '14 at 07:16

3 Answers3

2

When you create a regex from a string, you have to take into account the fact that the parser will strip out backslashes from the string before it has a chance to be parsed as a regex.

Thus, by the time the RegExp() constructor gets to work, all the \w tokens have already been changed to just plain "w" in the string constant. You can either double the backslashes so the string parse will leave just one, or you can use the native regex constant syntax instead.

Pointy
  • 405,095
  • 59
  • 585
  • 614
1

It works if you do this:

var mailValidator = /\w+([-+.]\w+)*@\w+([-.]\w+)*\.\w+([-.]\w+)*/;

What happens in yours is that you need to double escape the backslash because they're inside a string, like "\\w+([-+.]\\w+)*...etc

Here's a link that explains it (in the "How to Use The JavaScript RegExp Object" section).

cambraca
  • 27,014
  • 16
  • 68
  • 99
1

Try var mailValidator = new RegExp("\\w+([-+.]\\w+)*@\\w+([-.]\\w+)*\\.\\w+([-.]\\w+)*");

madhead
  • 31,729
  • 16
  • 153
  • 201