You certainly have a wonderful eye for detail.
Yes, broadly speaking, unless we can (in essence) connect every piece of our root-finding process with an "if and only if" statement, there might be information lost: we might introduce roots that weren't there to begin with. (The easy example is with $x = 1$; square it, and suddenly $-1$ is a root, but $x=1 \;\;\not \!\!\!\!\iff x^2 = 1$.)
- Do the statements in the answer have an if, then or an if and only if relationship? i.e., does the answer mean "$x-1=0 \iff x=1$" or "$x-1=0 \Rightarrow x=1$"?
It is an "if and only if" situation.
Suppose $x-1=0$. Add one to both sides to conclude that $x=1$.
Suppose $x=1$. Subtract one from both sides to conclude that $x-1=0$.
More broadly, if you "do the same thing" to both sides of an equation, and that operation is well-defined and injective (i.e. $f(x)=f(y) \implies x=y$; equivalently, $x \ne y \implies f(x) \ne f(y)$), then one can use "if and only if" as a sort of "logical connective".
- Would the answer be correct in the eyes of a teacher than demands 100% rigor? Or would it need to plug the values back into the polynomial to show the converse?
Now this is a question that almost merits two separate answers.
In the eyes of the person who demands perfect rigor, no, the proof in the OP might be sufficient and might not be. They might, in particular, expect every logical equivalence to be fully justified.
On the other hand, we are talking about a teacher. At some point in our mathematical education, we get a feel for statements that we can take for granted. I don't feel particularly obligated to mention explicit use of the quadratic formula or show the intermediate steps in my calculations, now that I'm well beyond calculus, unless I'm in some strange context or using different number systems. Even in my most rigorous math classes, such items could be taken for granted, for brevity's sake -- the rigor was exercised more on new material than on old stuff, unless it was particularly enlightening or important for said old material.
In that sense, even in a class with a high level of rigor (and assuming we're working over $\mathbb{C}$), I don't think a teacher would even look at $$x^2 - x = 0 \implies x \in \{0,1\}$$ as written with more than a passing glance. It's true, and you can certainly solve it.
This of course begs the third note -- you should ask your hypothetical teacher the level of rigor demanded to you by the work, and which items can be assumed and which cannot. Some expectations can probably be gleaned from class notes as well.
- Would writing the iff symbol before each equation be needed, correct, or bad practice (in proofs)?
Entirely fine; I do it often myself (when the intermediate steps are simple enough to merit an explanation limited to a small line of text), and have never been criticized for it. I'm not sure what else you could reasonably do if you want to show your work (aside from explaining each step line-by-line, but I feel like that would break the flow a lot).
- When a question says "P(x)=C. Solve for x.", is there a formal restatement of the question in symbolic logic?
No, because logical statements are just that -- statements, declarative in nature. They don't do imperatives like "solve for $x$" very well.