8

I sometimes run into small issues when doing my JavaScript projects. That is because most build in functions of JavaScript run X,Y if positions are needed. (In that order).

But when I build a 2D Array I start out with Y, it seems more logical for me to to run the X axis horizontal. If I am bad at explaining it, let me show you:

enter image description here

So my loops look like this:

for(var y = 0; y < 10; y++){
    for(var x = 0; x < 10; x++){
        console.log("Doh!");
    }
}

Is this so insane? I would like to convert to the normal practise so that I have an easier time while building my game and don't have to do constant switcherroos.

So why is it X before Y ?

Edit: Here is another example, and probably the main reason for my confusion: X is Horizontal, and Y is Vertical in my books..

[
[0,1,2,3,4],
[0,1,2,3,4],
[0,1,2,3,4],
[0,1,2,3,4],
]
Oliver Schöning
  • 452
  • 3
  • 15

3 Answers3

8

No, if it's working for you, you're not doing it wrong. If you'd like to switch, than do so. The order you process rows/columns is sometimes arbitrary, sometimes not. Which order you use depends entirely on the algorithm you're using.

There's multiple different combinations for processing X,Y. It's up to you to choose which one is correct for your algorithm. In the case where the each iteration is independent of any other, you can choose which ever one you want. You can switch which is in the inner loop and you can also switch if the loops go from min to max or max to min.

I imagine the default is:

for xmin to xmax
    for ymin to ymax

because this is often how the data is arranged in memory. (Not necessarily true for all languages as the order of the index can change).

For example, an array A[3][3] (A[X][Y]):

enter image description here

Where the y value is in the inner loop increments first and then "rolls over" to increment the x value. Other than that, (X,Y) is the standard way to write it in mathematics.

House
  • 73,224
  • 17
  • 184
  • 273
4

You are doing it wrong...sort of. The wrong thing you are doing is correlating the order in which coordinates are written with the order in which loops are nested. Those are totally different ideas!

More specifically, the wrong thing is that your coordinate system is tied in a strong (and brittle) way to your implementation of your data storage. That means you are designing bad code from an OO standpoint. The data storage should be opaque to the thing that uses it, and the thing that uses it should not care how the data is stored. The user of the data only needs to know how to get the piece of information that it wants.

What you should do is find a way to abstract away your nested array data structure, and hide it in a method like getPoint(x,y). Then you do not have to worry about which array is nested in which order. You could leave your backwards data structure exactly as it is, as long as your getter method knows to first find array y, and then seek within it for element x. But whatever code is calling getPoint() does not know that. It only needs to know the two coordinates it is interested in.

Seth Battin
  • 5,509
  • 3
  • 27
  • 43
  • In other words: "Programms don't care how pretty your code is!" – Oliver Schöning Mar 06 '13 at 04:55
  • But is there anything wrong with my way of storing it besides being upside down? – Oliver Schöning Mar 06 '13 at 04:56
  • No, I don't think so; the other answers are correct in that way. My point is only about how it causes you confusion, which I inferred from the fact that you asked. If your implementation makes your code hard to understand, then encapsulate that weirdness behind a good interface and forget about it. – Seth Battin Mar 06 '13 at 05:00
1

It does not matter! I also always write Y first (looks more natural). When you have your matrix in array as rows, you can even do some optmization. Instead of this:

for(var y=0; y<h; y++){
    for(var x=0; x<w; x++){
        m[y*w+x] = a;
    }
}

you can use this:

for(var y=0; y<h; y++){
    var i = y*w;
    for(var x=0; x<w; x++, i++){
        m[i] = a;
    }
}

and avoid lots of multiplications! :)

Ivan Kuckir
  • 1,184
  • 8
  • 13
  • Could you tell me what your second example does better? :o In JavaScript there are no "real" 2D arrays, you have to create an array of arrays. I therefore don't know if I can use the second example. – Oliver Schöning Mar 05 '13 at 23:27
  • Let's say, w=h=1000. In first example, you are doint 1000000 multiplications, while in second example, you are doing only 1000 multiplications. Multiplication is super hard, many CPUs don't even have multiplication command. They are emulating it with addition and bit operations. – Ivan Kuckir Mar 06 '13 at 00:57
  • I see. But I just don't see myself doing such a iteration. Mine usually look like this: for(var y ...){array[y]=[] for(var x ...){ array[y][x] = a;}} – Oliver Schöning Mar 06 '13 at 01:09
  • 1
    Oh sure. But you are creating 1000 new JS objects on heap ... oh never mind, you are probably not implementing Adobe Photoshop in JS, so keep using your iterations :) – Ivan Kuckir Mar 06 '13 at 09:46